Code suggestions #8

Merged
Piotr Icikowski merged 4 commits from refactor into devel 2024-03-02 16:30:27 +01:00
Showing only changes of commit ea92b2979c - Show all commits

View File

@ -35,44 +35,28 @@ func New(options ...Option) (Kubeprobes, error) {
} }
func (kp *kubeprobes) validate() error { func (kp *kubeprobes) validate() error {
errs := []error{} var err error
if kp.pathLive == "" { if kp.pathLive == "" {
errs = append( err = errors.Join(err, fmt.Errorf("liveness probe path must not be empty"))
errs,
fmt.Errorf("liveness probe path must not be empty"),
)
} }
if kp.pathReady == "" { if kp.pathReady == "" {
errs = append( err = errors.Join(err, fmt.Errorf("readiness probe path must not be empty"))
errs,
fmt.Errorf("readiness probe path must not be empty"),
)
} }
if !strings.HasPrefix(kp.pathLive, "/") { if !strings.HasPrefix(kp.pathLive, "/") {
errs = append( err = errors.Join(err, fmt.Errorf("liveness probe path must start with slash (current: %q)", kp.pathLive))
errs,
fmt.Errorf("liveness probe path must start with slash (current: %q)", kp.pathLive),
)
} }
if !strings.HasPrefix(kp.pathReady, "/") { if !strings.HasPrefix(kp.pathReady, "/") {
errs = append( err = errors.Join(err, fmt.Errorf("readiness probe path must start with slash (current: %q)", kp.pathReady))
errs,
fmt.Errorf("readiness probe path must start with slash (current: %q)", kp.pathReady),
)
} }
if kp.pathLive == kp.pathReady { if kp.pathLive == kp.pathReady {
errs = append( err = errors.Join(err, fmt.Errorf("liveness and readiness probes have the same values (both %q)", kp.pathLive))
errs,
fmt.Errorf("liveness and readiness probes have the same values (both %q)", kp.pathLive),
)
} }
return errors.Join(errs...) return err
} }
func (kp *kubeprobes) handleLiveness(w http.ResponseWriter, _ *http.Request) { func (kp *kubeprobes) handleLiveness(w http.ResponseWriter, _ *http.Request) {